Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 16:56:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #954 from mitchellh/kitty-jp

Browse Source 
input: kitty encoding should ignore committed preedit state
This commit is contained in:
Mitchell Hashimoto
2023-11-24 08:02:16 -08:00
committed by GitHub
parent bf30c38945 a67d90710c
commit 07166fc9d2
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/input/KeyEncoder.zig
View File

@ -87,6 +87,15 @@ fn kitty(
return "";
}
// IME confirmation still sends an enter key so if we have enter
// and UTF8 text we just send it directly since we assume that is
// whats happening.
if (self.event.key == .enter and
self.event.utf8.len > 0)
{
return try copyToBuf(buf, self.event.utf8);
}
// If we're reporting all then we always send CSI sequences.
if (!self.kitty_flags.report_all) {
// Quote:
@ -1177,6 +1186,25 @@ test "kitty: alternates omit control characters" {
try testing.expectEqualStrings("\x1b[3~", actual);
}
test "kitty: enter with utf8 (dead key state)" {
var buf: [128]u8 = undefined;
var enc: KeyEncoder = .{
.event = .{
.key = .enter,
.utf8 = "A",
.unshifted_codepoint = 0x0D,
},
.kitty_flags = .{
.disambiguate = true,
.report_alternates = true,
.report_all = true,
},
};
const actual = try enc.kitty(&buf);
try testing.expectEqualStrings("A", actual);
}
test "legacy: enter with utf8 (dead key state)" {
var buf: [128]u8 = undefined;
var enc: KeyEncoder = .{