Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-17 09:16:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1689 from mitchellh/macos-fs

Browse Source 
macos: show alert when creating new tab in non-native fs
This commit is contained in:
Mitchell Hashimoto
2024-04-16 09:39:20 -07:00
committed by GitHub
parent acf823fe3a 45eecf801e
commit 06c5528a59
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
macos/Sources/Features/Terminal/TerminalController.swift
View File

@ -34,7 +34,7 @@ class TerminalController: NSWindowController, NSWindowDelegate,
} }
/// Fullscreen state management. /// Fullscreen state management.
private let fullscreenHandler = FullScreenHandler() let fullscreenHandler = FullScreenHandler()
/// True when an alert is active so we don't overlap multiple. /// True when an alert is active so we don't overlap multiple.
private var alert: NSAlert? = nil private var alert: NSAlert? = nil

13
macos/Sources/Features/Terminal/TerminalManager.swift
View File

@ -105,6 +105,19 @@ class TerminalManager {
} }
private func newTab(to parent: NSWindow, withBaseConfig base: Ghostty.SurfaceConfiguration?) { private func newTab(to parent: NSWindow, withBaseConfig base: Ghostty.SurfaceConfiguration?) {
// If our parent is in non-native fullscreen, then new tabs do not work.
// See: https://github.com/mitchellh/ghostty/issues/392
if let controller = parent.windowController as? TerminalController,
controller.fullscreenHandler.isInNonNativeFullscreen {
let alert = NSAlert()
alert.messageText = "Cannot Create New Tab"
alert.informativeText = "New tabs are unsupported while in non-native fullscreen. Exit fullscreen and try again."
alert.addButton(withTitle: "OK")
alert.alertStyle = .warning
alert.beginSheetModal(for: parent)
return
}
// Create a new window and add it to the parent // Create a new window and add it to the parent
let controller = createWindow(withBaseConfig: base) let controller = createWindow(withBaseConfig: base)
let window = controller.window! let window = controller.window!