Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 08:46:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

font: if CoreText needs to allocate, stack allocate and log

Browse Source
This commit is contained in:
Mitchell Hashimoto
2023-05-31 22:03:27 -07:00
parent d903e4a43b
commit 01de38b20d
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/font/DeferredFace.zig
View File

@ -113,7 +113,21 @@ pub fn name(self: DeferredFace) ![:0]const u8 {
.coretext, .coretext_freetype => if (self.ct) |ct| { .coretext, .coretext_freetype => if (self.ct) |ct| {
const display_name = ct.font.copyDisplayName(); const display_name = ct.font.copyDisplayName();
return display_name.cstringPtr(.utf8) orelse "<unsupported internal encoding>"; return display_name.cstringPtr(.utf8) orelse unsupported: {
// "NULL if the internal storage of theString does not allow
// this to be returned efficiently." In this case, we need
// to allocate. But we can't return an allocated string because
// we don't have an allocator. Let's use the stack and log it.
var buf: [1024]u8 = undefined;
const buf_name = display_name.cstring(&buf, .utf8) orelse
"<not enough internal storage space>";
log.info(
"CoreText font required too much space to copy, value = {s}",
.{buf_name},
);
break :unsupported "<CoreText internal storage limited, see logs>";
};
}, },
.web_canvas => if (self.wc) |wc| return wc.font_str, .web_canvas => if (self.wc) |wc| return wc.font_str,