apprt: remove change conditional state action

This commit is contained in:
Mitchell Hashimoto
2024-11-22 11:33:15 -08:00
parent 266e4781fb
commit 00c62708d3
5 changed files with 0 additions and 35 deletions

View File

@ -577,7 +577,6 @@ typedef enum {
GHOSTTY_ACTION_SECURE_INPUT, GHOSTTY_ACTION_SECURE_INPUT,
GHOSTTY_ACTION_KEY_SEQUENCE, GHOSTTY_ACTION_KEY_SEQUENCE,
GHOSTTY_ACTION_COLOR_CHANGE, GHOSTTY_ACTION_COLOR_CHANGE,
GHOSTTY_ACTION_CONFIG_CHANGE_CONDITIONAL_STATE,
GHOSTTY_ACTION_RELOAD_CONFIG, GHOSTTY_ACTION_RELOAD_CONFIG,
GHOSTTY_ACTION_CONFIG_CHANGE, GHOSTTY_ACTION_CONFIG_CHANGE,
} ghostty_action_tag_e; } ghostty_action_tag_e;

View File

@ -194,13 +194,6 @@ pub const Action = union(Key) {
/// such as OSC 10/11. /// such as OSC 10/11.
color_change: ColorChange, color_change: ColorChange,
/// The state of conditionals in the configuration has changed, so
/// the configuration should be reloaded. The apprt doesn't need
/// to do a full physical reload; it should call the
/// `changeConditionalState` function and then `updateConfig`
/// on the app or surface.
config_change_conditional_state,
/// A request to reload the configuration. The reload request can be /// A request to reload the configuration. The reload request can be
/// from a user or for some internal reason. The reload request may /// from a user or for some internal reason. The reload request may
/// request it is a soft reload or a full reload. See the struct for /// request it is a soft reload or a full reload. See the struct for
@ -259,7 +252,6 @@ pub const Action = union(Key) {
secure_input, secure_input,
key_sequence, key_sequence,
color_change, color_change,
config_change_conditional_state,
reload_config, reload_config,
config_change, config_change,
}; };

View File

@ -450,30 +450,6 @@ pub const App = struct {
}, },
}, },
.config_change_conditional_state => switch (target) {
.app => {},
.surface => |surface| action: {
// Build our new configuration. We can free the memory
// immediately after because the surface will derive any
// values it needs to.
var new_config = self.config.changeConditionalState(
surface.config_conditional_state,
) catch |err| {
// Not a big deal if we error... we just don't update
// the config. We log the error and move on.
log.warn("error changing config conditional state err={}", .{err});
break :action;
};
defer new_config.deinit();
// Update our surface.
surface.updateConfig(&new_config) catch |err| {
log.warn("error updating surface config for state change err={}", .{err});
break :action;
};
},
},
else => {}, else => {},
} }
} }

View File

@ -227,7 +227,6 @@ pub const App = struct {
.renderer_health, .renderer_health,
.color_change, .color_change,
.pwd, .pwd,
.config_change_conditional_state,
.config_change, .config_change,
=> log.info("unimplemented action={}", .{action}), => log.info("unimplemented action={}", .{action}),
} }

View File

@ -490,7 +490,6 @@ pub fn performAction(
.renderer_health, .renderer_health,
.color_change, .color_change,
.config_change, .config_change,
.config_change_conditional_state,
=> log.warn("unimplemented action={}", .{action}), => log.warn("unimplemented action={}", .{action}),
} }
} }